Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[For Test] Upgrade 'spring-boot-starter-parent' to 2.5.0-RC1. #20010

Closed

Conversation

chenrujun
Copy link

@chenrujun chenrujun commented Mar 22, 2021

This PR is used to test whether there is dependency problem if upgrade to spring-boot-2.5.0-M3.

  1. Upgrade 'spring-boot-starter-parent' to 2.5.0-M3.
  2. Upgrade 'spring-boot-dependencies' to 2.5.0-M3.
  3. Upgrade 'spring-cloud-dependencies' to 2020.0.2.
  4. Update pom.py to fit Spring milestone repo.

@chenrujun chenrujun force-pushed the update-spring-boot-version-to-2.5.0-M3 branch from dc0a6cb to a8e9bb1 Compare April 23, 2021 09:01
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

@chenrujun chenrujun requested a review from aayush3011 as a code owner April 25, 2021 03:10
@chenrujun
Copy link
Author

/azp run java - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@chenrujun
Copy link
Author

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@@ -45,6 +54,12 @@
<artifactId>azure-spring-cloud-starter-eventhubs-kafka</artifactId>
<version>2.5.0-beta.1</version> <!-- {x-version-update;com.azure.spring:azure-spring-cloud-starter-eventhubs-kafka;current} -->
</dependency>
<!-- Related issue: https://github.com/spring-cloud/spring-cloud-stream-binder-kafka/issues/1062 -->
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chenrujun
Copy link
Author

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@chenrujun
Copy link
Author

/azp run java - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@chenrujun
Copy link
Author

chenrujun commented Apr 26, 2021

Great! All tests passed. 😄

(cc: @saragluna @stliu , FYI.)

@chenrujun chenrujun self-assigned this May 11, 2021
@chenrujun chenrujun added this to the [2021] June milestone May 11, 2021
@chenrujun chenrujun closed this May 17, 2021
chenrujun pushed a commit to chenrujun/azure-sdk-for-java that referenced this pull request May 26, 2021
@chenrujun chenrujun deleted the update-spring-boot-version-to-2.5.0-M3 branch June 8, 2021 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure-spring All azure-spring related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spring - test to upgrade to Spring Boot 2.5.0-M*
3 participants